Skip to content

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented Oct 8, 2025

The space after & made it look like the & was not part of the signature, possibly leading to confusion why the two signatures are incompatible without carefully reading the message.

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed previously, I'm in favor of the idea.
I think hooks may need a tweak though.

…_function_declaration()

The space after `&` made it look like the `&` was not part of the signature,
possibly leading to confusion why the two signatures are incompatible without
carefully reading the message.
@TimWolla TimWolla force-pushed the function-signature-error-return-ref branch from d87c9bd to c7f7af9 Compare October 17, 2025 08:47
@TimWolla TimWolla merged commit 7c9c395 into php:master Oct 19, 2025
10 checks passed
@TimWolla TimWolla deleted the function-signature-error-return-ref branch October 19, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants